Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Data Structures Exploring the Java Collection Framework ArrayLists

getexternallinks

I feel like it's correct but it's obviously not. They are expecting 3 link but receiving 13.

Where did I go wrong with the getExternalLinks method?

Thanks

AJ

com/example/BlogPost.java
package com.example;

import java.io.Serializable;
import java.util.*;


public class BlogPost implements Comparable<BlogPost>, Serializable {
  private String mAuthor;
  private String mTitle;
  private String mBody;
  private String mCategory;
  private Date mCreationDate;

  public BlogPost(String author, String title, String body, String category, Date creationDate) {
    mAuthor = author;
    mTitle = title;
    mBody = body;
    mCategory = category;
    mCreationDate = creationDate;
  }

  public int compareTo(BlogPost other) {
    if (equals(other)) {
      return 0;
    }
    return mCreationDate.compareTo(other.mCreationDate);
  }

  public String[] getWords() {
    return mBody.split("\\s+");
  }

  public List<String> getExternalLinks() {
    List<String> results = new ArrayList<String>();
    for (String word : getWords()){
      if (word.startsWith("http"));{
        results.add(word);
      }  
    }
    return results;
  }


  public String getAuthor() {
    return mAuthor;
  }

  public String getTitle() {
    return mTitle;
  }

  public String getBody() {
    return mBody;
  }

  public String getCategory() {
    return mCategory;
  }

  public Date getCreationDate() {
    return mCreationDate;
  }
}

1 Answer

Hi

Hard to tell without seeing the input. Have you tried

for (String word : getWords()){ System.out.printf("the word is: %s", word); /// <<<<<<<<<<<<<<<<<<<<<< if (word.startsWith("http"));{ results.add(word); }
}

this should give a clue as how the original string was split.

But I see a problem here:

for (String word : getWords()){ if (word.startsWith("http"));{ results.add(word); }

you should change to: List<String> splittedString = getWords(); for (String word : splittedString ){ if (word.startsWith("http"));{ results.add(word); }