Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by MIHA W.LEE
.a{fill-rule:evenodd;}techdegree seal-36
MIHA W.LEE
PHP Development Techdegree Graduate 25,452 Points

Getter and Setter

I wrote my own logic at here, just i don t know where s my logic wrong.

Hope someone can help me out,thank you so much!

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        } 
    }

   set major(x) {
        var score = this._major = x;
     if(level() == 'Junior' || level() == 'Senior') {return score }
     if(level() == 'Freshman' || level() == 'Sophomore') {return score = null}
   }
}

var student = new Student(3.9, 60);

1 Answer

KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,967 Points

Some hints:

  • Setters don't return values they set them. Returning values is what getters are for
  • You have the right idea with this._major = x for what the setter should do
  • For Freshman and Sophomore this._major = 'None'
  • In your setter you should be checking the instance value of level by using this.level
MIHA W.LEE
.a{fill-rule:evenodd;}techdegree seal-36
MIHA W.LEE
PHP Development Techdegree Graduate 25,452 Points

Thank you so much!