Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Ruby User Authentication with Rails Password Hashing and Sign In Creating the User Model: Part 1

alborz
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
alborz
Full Stack JavaScript Techdegree Graduate 30,884 Points

Getting a bunch of errors in test after running bin/rake

Hi,

I downloaded the app from the tutorial.

So near the end of the video, after I run bin/rake I get the following output:

  1) UsersController POST create with valid params redirects to the created user
     Failure/Error: response.should redirect_to(User.last)
       Expected response to be a <redirect>, but was <200>
     # ./spec/controllers/users_controller_spec.rb:64:in `block (4 levels) in <top (required)>'

  2) UsersController POST create with valid params assigns a newly created user as @user
     Failure/Error: assigns(:user).should be_persisted
       expected persisted? to return true, got false
     # ./spec/controllers/users_controller_spec.rb:59:in `block (4 levels) in <top (required)>'

  3) UsersController POST create with valid params creates a new User
     Failure/Error: expect {
       count should have been changed by 1, but was changed by 0
     # ./spec/controllers/users_controller_spec.rb:51:in `block (4 levels) in <top (required)>'

  4) UsersController GET edit assigns the requested user as @user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:42:in `block (3 levels) in <top (required)>'

  5) UsersController PUT update with valid params redirects to the user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:104:in `block (4 levels) in <top (required)>'

  6) UsersController PUT update with valid params assigns the requested user as @user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:98:in `block (4 levels) in <top (required)>'

  7) UsersController PUT update with valid params updates the requested user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:88:in `block (4 levels) in <top (required)>'

  8) UsersController PUT update with invalid params assigns the user as @user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:112:in `block (4 levels) in <top (required)>'

  9) UsersController PUT update with invalid params re-renders the 'edit' template
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:120:in `block (4 levels) in <top (required)>'

  10) UsersController DELETE destroy destroys the requested user
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:131:in `block (3 levels) in <top (required)>'

  11) UsersController DELETE destroy redirects to the users list
     Failure/Error: user = User.create! valid_attributes
     ActiveRecord::RecordInvalid:
       Validation failed: Email can't be blank
     # ./spec/controllers/users_controller_spec.rb:138:in `block (3 levels) in <top (required)>'

Finished in 2.44 seconds
89 examples, 11 failures

Failed examples:

rspec ./spec/controllers/users_controller_spec.rb:62 # UsersController POST create with valid params redirects to the created user
rspec ./spec/controllers/users_controller_spec.rb:56 # UsersController POST create with valid params assigns a newly created user as @user
rspec ./spec/controllers/users_controller_spec.rb:50 # UsersController POST create with valid params creates a new User
rspec ./spec/controllers/users_controller_spec.rb:41 # UsersController GET edit assigns the requested user as @user
rspec ./spec/controllers/users_controller_spec.rb:103 # UsersController PUT update with valid params redirects to the user
rspec ./spec/controllers/users_controller_spec.rb:97 # UsersController PUT update with valid params assigns the requested user as @user
rspec ./spec/controllers/users_controller_spec.rb:87 # UsersController PUT update with valid params updates the requested user
rspec ./spec/controllers/users_controller_spec.rb:111 # UsersController PUT update with invalid params assigns the user as @user
rspec ./spec/controllers/users_controller_spec.rb:119 # UsersController PUT update with invalid params re-renders the 'edit' template
rspec ./spec/controllers/users_controller_spec.rb:130 # UsersController DELETE destroy destroys the requested user
rspec ./spec/controllers/users_controller_spec.rb:137 # UsersController DELETE destroy redirects to the users list

Here is my users_controller_spec.rb file:

require 'spec_helper'

# This spec was generated by rspec-rails when you ran the scaffold generator.
# It demonstrates how one might use RSpec to specify the controller code that
# was generated by Rails when you ran the scaffold generator.
#
# It assumes that the implementation code is generated by the rails scaffold
# generator.  If you are using any extension libraries to generate different
# controller code, this generated spec may or may not pass.
#
# It only uses APIs available in rails and/or rspec-rails.  There are a number
# of tools you can use to make these specs even more expressive, but we're
# sticking to rails and rspec-rails APIs to keep things simple and stable.
#
# Compared to earlier versions of this generator, there is very limited use of
# stubs and message expectations in this spec.  Stubs are only used when there
# is no simpler way to get a handle on the object needed for the example.
# Message expectations are only used when there is no simpler way to specify
# that an instance is receiving a specific message.

describe UsersController do

  # This should return the minimal set of attributes required to create a valid
  # User. As you add validations to User, be sure to
  # adjust the attributes here as well.
  let(:valid_attributes) { { "first_name" => "MyString" } }

  # This should return the minimal set of values that should be in the session
  # in order to pass any filters (e.g. authentication) defined in
  # UsersController. Be sure to keep this updated too.
  let(:valid_session) { {} }

  describe "GET new" do
    it "assigns a new user as @user" do
      get :new, {}, valid_session
      assigns(:user).should be_a_new(User)
    end
  end

  describe "GET edit" do
    it "assigns the requested user as @user" do
      user = User.create! valid_attributes
      get :edit, {:id => user.to_param}, valid_session
      assigns(:user).should eq(user)
    end
  end

  describe "POST create" do
    describe "with valid params" do
      it "creates a new User" do
        expect {
          post :create, {:user => valid_attributes}, valid_session
        }.to change(User, :count).by(1)
      end

      it "assigns a newly created user as @user" do
        post :create, {:user => valid_attributes}, valid_session
        assigns(:user).should be_a(User)
        assigns(:user).should be_persisted
      end

      it "redirects to the created user" do
        post :create, {:user => valid_attributes}, valid_session
        response.should redirect_to(User.last)
      end
    end

    describe "with invalid params" do
      it "assigns a newly created but unsaved user as @user" do
        # Trigger the behavior that occurs when invalid params are submitted
        User.any_instance.stub(:save).and_return(false)
        post :create, {:user => { "first_name" => "invalid value" }}, valid_session
        assigns(:user).should be_a_new(User)
      end

      it "re-renders the 'new' template" do
        # Trigger the behavior that occurs when invalid params are submitted
        User.any_instance.stub(:save).and_return(false)
        post :create, {:user => { "first_name" => "invalid value" }}, valid_session
        response.should render_template("new")
      end
    end
  end

  describe "PUT update" do
    describe "with valid params" do
      it "updates the requested user" do
        user = User.create! valid_attributes
        # Assuming there are no other users in the database, this
        # specifies that the User created on the previous line
        # receives the :update_attributes message with whatever params are
        # submitted in the request.
        User.any_instance.should_receive(:update).with({ "first_name" => "MyString" })
        put :update, {:id => user.to_param, :user => { "first_name" => "MyString" }}, valid_session
      end

      it "assigns the requested user as @user" do
        user = User.create! valid_attributes
        put :update, {:id => user.to_param, :user => valid_attributes}, valid_session
        assigns(:user).should eq(user)
      end

      it "redirects to the user" do
        user = User.create! valid_attributes
        put :update, {:id => user.to_param, :user => valid_attributes}, valid_session
        response.should redirect_to(user)
      end
    end

    describe "with invalid params" do
      it "assigns the user as @user" do
        user = User.create! valid_attributes
        # Trigger the behavior that occurs when invalid params are submitted
        User.any_instance.stub(:save).and_return(false)
        put :update, {:id => user.to_param, :user => { "first_name" => "invalid value" }}, valid_session
        assigns(:user).should eq(user)
      end

      it "re-renders the 'edit' template" do
        user = User.create! valid_attributes
        # Trigger the behavior that occurs when invalid params are submitted
        User.any_instance.stub(:save).and_return(false)
        put :update, {:id => user.to_param, :user => { "first_name" => "invalid value" }}, valid_session
        response.should render_template("edit")
      end
    end
  end

  describe "DELETE destroy" do
    it "destroys the requested user" do
      user = User.create! valid_attributes
      expect {
        delete :destroy, {:id => user.to_param}, valid_session
      }.to change(User, :count).by(-1)
    end

    it "redirects to the users list" do
      user = User.create! valid_attributes
      delete :destroy, {:id => user.to_param}, valid_session
      response.should redirect_to(users_url)
    end
  end

end

Thanks!

1 Answer

Hi Alborz,

Your rspec User controller tests are failing because you haven't provided the minimal set of attributes required to create a valid User. The spec that you have was automatically generated by rspec-rails when you ran the scaffold generate command. The spec is just an outline to get you started, it is not intended to be used as is. Also, check your model to be sure that you have the validations needed for rspec to run the tests against. My recommendation is to carefully review the spec outline (initially focus your attention on the "#commented out" language in green), read everything carefully, and see if you can identify what you need to put in your User model and spec to effectively use rspec.

I hope this answer gets you moving in the right direction. Keep working on testing. Getting into testing has really helped me to understand Rails better. Keep at it!

Best,

Ronald