Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python (retired) Inheritance Instance Methods

Getting Back None as weapon

If I put in s a or b right away I get correct info however if I put in anything else first and then put in s a or b I get none as the weapon type.

class Character(object):
    experience = 0
    hit_points = 10

    def get_weapon(self):
        weapon_choice = input("Weapon ([S]word, [A]xe, [B]ow: ").lower()
        if weapon_choice in 'sab':
            if weapon_choice == 's':
                return 'sword'
            elif weapon_choice == 'a':
                return 'axe'
            else:
                return 'bow'
        else:
            self.get_weapon()

    def __init__(self, **kwargs):
        self.name = input("Name: ")
        self.weapon = self.get_weapon()
        for key, value in kwargs.items():
            setattr(self, key, value)

from monster import *
from character import Character

azog = Troll()
snaga = Goblin()
draco = Dragon()
player1 = Character()


print(azog)
print(snaga)
print(draco)
print(player1.name)
print(player1.weapon)
print(player1.experience)
print(player1.hit_points)
Output:
Name: Brad
Weapon ([S]word, [A]xe, [B]ow: asd
Weapon ([S]word, [A]xe, [B]ow: s

Yellow, Troll, HP: 3, XP 3
Green, Goblin, HP: 1, XP 1
Green, Dragon, HP: 5, XP 9
Brad
None
0
10

[MOD: added ```python formatting -cf]

1 Answer

I got the answer did not have return after the last else:

return self.get_weapon()

Kevin Faust
Kevin Faust
15,353 Points

ha! thats funny. i had the exact same problem as you