Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Dylan Fried
Dylan Fried
3,123 Points

Good guesses are tallied as strikes.

For some reason when I guess a correct letter it'll display the letter at the position of the word; but it will also count it as a strike. Also, if i guess a letter that is not correct then it won't do anything.

import os
import random
import sys



words = ['apples', 'banana', 'cherry', 'kiwi', 'coconut', 'strawberry', 'lime', 'grapefruit', 'lemon', 'melon']

def clear():
    if os.name == 'nt':
        os.system('cls')
    else:
        os.system('clear')

def draw(bad_guesses, good_guesses, secret_word):
    clear()

    print('Strikes: {}/7'.format(len(bad_guesses)))
    print('')

    for letter in bad_guesses:
        print(letter, end=' ')
    print('\n\n')

    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')

    print('')

def get_guess(bad_guesses, good_guesses):
    while True:
        guess = input("Guess a letter: ").lower()

        if len(guess) !=1:
            print("You can only guess a single letter!")
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already gussed that letter!")
        elif not guess.isalpha():
            print("You can only guess letters!")
        else:
            return guess

def play(done):
    clear()
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while True:
        draw(bad_guesses, good_guesses, secret_word)
        guess = get_guess(bad_guesses, good_guesses)

        if guess in secret_word:
            good_guesses.append(guess)
            found = True
            for letter in secret_word:
                if letter not in good_guesses:
                    found = False
            if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))
                done = True
            else:
                bad_guesses.append(guess)
                if len(bad_guesses) == 7:
                    draw(bad_guesses, good_guesses, secret_word)
                    print("You lost!")
                    print("The secret word was {}".format(secret_word))
                    done = True
            if done:
                play_again = input("Play again? Y/n ").lower()
                if play_again !='n':
                    return play(done=False)
                else:
                    sys.exit()








def welcome():
    start = input("Press enter/return to start, or Q to quit ")
    if start == 'q':
        print("Bye!")
        sys.exit()
    else:
        return True

print('Welcome to letter Guess!')

done = False

while True:
    clear()
    welcome() 
    play(done)

1 Answer

Valeriya Romashchenko
Valeriya Romashchenko
11,841 Points

I've tried your code. You intended else block of code in the game function inside of 

if guess in secret_word:

and thus this else statement let's say works with the 

if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))
                done = True

same with the "if done". The number of the strikes increments with checking the length of the bad_guesses list. If the number increments when your guess is correct this means the good guesses append to the bad guesses list. This is why I checked the line in the code where you need to sort and append good guesses and bad guesses in the corresponding list. I noticed that the logic is confusing because you append a letter into the bad_guesses list inside of the if condition when the letter is in the secret word (which is a correct guess). When I aligned those blocks of code with the first if statement "if guess in secret_word:" the game worked correctly:

import os
import random
import sys



words = ['apples', 'banana', 'cherry', 'kiwi', 'coconut', 'strawberry', 'lime', 'grapefruit', 'lemon', 'melon']

def clear():
    if os.name == 'nt':
        os.system('cls')
    else:
        os.system('clear')

def draw(bad_guesses, good_guesses, secret_word):
    clear()

    print('Strikes: {}/7'.format(len(bad_guesses)))
    print('')

    for letter in bad_guesses:
        print(letter, end=' ')
    print('\n\n')

    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')

    print('')

def get_guess(bad_guesses, good_guesses):
    while True:
        guess = input("Guess a letter: ").lower()

        if len(guess) !=1:
            print("You can only guess a single letter!")
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already gussed that letter!")
        elif not guess.isalpha():
            print("You can only guess letters!")
        else:
            return guess

def play(done):
    clear()
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while True:
        draw(bad_guesses, good_guesses, secret_word)
        guess = get_guess(bad_guesses, good_guesses)

        if guess in secret_word:
            good_guesses.append(guess)
            found = True
            for letter in secret_word:
                if letter not in good_guesses:
                    found = False
            if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))
                done = True
        else:
            bad_guesses.append(guess)
            if len(bad_guesses) == 7:
                draw(bad_guesses, good_guesses, secret_word)
                print("You lost!")
                print("The secret word was {}".format(secret_word))
                done = True
        if done:
            play_again = input("Play again? Y/n ").lower()
            if play_again !='n':
                return play(done=False)
            else:
                sys.exit()








def welcome():
    start = input("Press enter/return to start, or Q to quit ")
    if start == 'q':
        print("Bye!")
        sys.exit()
    else:
        return True

print('Welcome to letter Guess!')

done = False

while True:
    clear()
    welcome() 
    play(done)
Dylan Fried
Dylan Fried
3,123 Points

Thank you for the help, and explanation!!!

Valeriya Romashchenko
Valeriya Romashchenko
11,841 Points

You are welcome! I'm glad I could help you)