Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Daniel Kiel
Daniel Kiel
3,433 Points
Posted by Daniel Kiel
Daniel Kiel
3,433 Points

Hello, my solution is working. What exactly I'm missing? It still show" Bummer: Did you select all 7 list items?"

My Code is putting colors/text on the right order but system still shows there's an error. Thank you!

``` var listItems; var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

listItems = document.getElementById('rainbow');

for(var i = 0; i < colors.length; i ++) { listItems.children[i].style.color = colors[i];

}```

js/app.js 
var listItems;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

listItems = document.getElementById('rainbow');

for(var i = 0; i < colors.length; i ++) {
  listItems.children[i].style.color = colors[i];    

}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Unsubscribed User
seal-mask
.a{fill-rule:evenodd;}techdegree
Unsubscribed User
Front End Web Development Techdegree Student 33,900 Points
Unsubscribed User
.a{fill-rule:evenodd;}techdegree
Unsubscribed User
Front End Web Development Techdegree Student 33,900 Points

Hi Daniel,

you are very close...

And actually the way you did it works indeed - it just is not how it is asked to be solved. ;-)

The task is to set the variable listItems to refer to a COLLECTION immediately (not just the "rainbow" id), so you don't have to use "children" further down below...

So you want to use querySelectorAll to select all list items directly, not querySelector. Remember you can chain selectors to target all list items, like for example:

var yourVariable = document.querySelectorAll("#main-text p span");

Can you figure it out with this hint? ;-)

Let me know if not!

Blessings from Berlin and happy java-scripting, Nils

PS: If my answer helped you or solved your issues, please upvote my answer and/or mark it as "Best answer" (so people browsing the community forum know your issue is solved)