Help improve my code

Question

Anyone have some ideas on how to improve my solution to this assignment? I really enjoyed this one and am proud of my work but I am curious what suggestions and tips you guys may have.

/* 
Assignment

Imagine that you are asked to build a todo app that keeps track of tasks. A task is broken down into the following:

Description
Status: Doing, Pending, Completing
The Description of the task describes what needs to get done. The Status on the other hand can and should have only 3 values: Doing, Pending, Completed. Your assignment is to model a Task struct which will have two properties description and status. However, here's the catch to use Status you will have to create your own enum.
*/

struct Task {
    var description : String

    enum Status {
        case Doing,
        Pending,
        Completed
        init() {
            self = .Pending
        }
    }

    var status = Status()

    init(description: String) {
        self.description = description
    }

    func printStatus() {
        let status = self.status
        if status == Task.Status.Completed {
            println("This task has been completed")
        } else if status == Task.Status.Doing {
            println("This task is being done")
        } else if status == Task.Status.Pending {
            println("This task is pending")
        } else {
            println("Error! I don't know what the status is.")
        }
    }
}

var assignment = Task(description: "Build a task manager")
assignment.printStatus()
assignment.status = .Doing
assignment.printStatus()
assignment.status = .Completed
assignment.printStatus()

Note: my reasoning for placing the Status enum within the struct was because I do not intend (nor see a use for) accessing Status independent of Task.

Answer 1 · 2015-07-06T01:56:02Z

July 6, 2015 1:56am

Your code looks good, the reasoning of the Enum within the Struct is correct given that other parts of the application won't use Status alone. One improvement I'd make is convert the if-else if-else structure of the function printStatus to switch statement, it'll make your code more readable, and under some circumnstances may have better performance.

func printStatus() {        
        switch self.status {
            case .Completed:
                println("This task has been completed")
            case .Doing:
                println("This task is being done")
            case .Pending:
                println("This task is pending")
            default:
                println("Error! I don't know what the status is.")
        }
    }

Welcome to the Treehouse Community

Looking to learn something new?

Joshua Rystedt

Joshua Rystedt

Help improve my code

1 Answer

Enrique Munguía

Enrique Munguía

Joshua Rystedt

Joshua Rystedt

Noel Deles

Noel Deles