Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Delivering the MVP Applying a Discount Code

Tyler Comley
Tyler Comley
1,413 Points

Help with compiling errors regarding my isLetter method.

So, I am trying to see if the code that I have typed up in the normalizeDiscountCode method works and is is giving me a compiler error saying it is expecting a variable and I am giving it a value. What I don't understand is why is it not working here and how should I rewrite my code so it does work? I was cross checking with the workspace in the Game.java file and the if statement "if (! Character.isLetter(letter))" has no issues. I can't even get the isLetter boolean method to work let alone try to get it to work with the "= false" or "!= true" comparisons to work. What am I doing wrong or what am I missing?

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private String normalizeDiscountCode(String discountCode) {
    discountCode = discountCode.toUpperCase();
    for (int i = 0; i <= discountCode.length();) {
      char discountChar = discountCode.charAt(i);
      if (Character.isLetter(discountChar) = false){
        throw new IllegalArgumentException("Invalid discount code");
      }
      i++;
    }
    return discountCode;
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

karol Zajączkowski
karol Zajączkowski
3,236 Points

if (Character.isLetter(discountChar) == false) - '=' you assign value and '==' you check if argument is true. for (int i = 0; i <= discountCode.length()-1;) - because char discountChar = discountCode.charAt(i); -> it starts from 0 and length() counts from 1.