Python Python Basics (2015) Shopping List App Refactor

Dolapo Sekoni
PRO
Dolapo Sekoni
Pro Student 1,431 Points

help with refractoring

kindly help check what could be wrong

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

show_help()

# make a list to hold onto our items
shopping_list = []

while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)

def main():

    show_help()

    # make a list to hold onto our items
    shopping_list = []

    While True:
        # ask for new items
        new_item = input("> ")

        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)
    show_list(shopping_list)

4 Answers

Steven Parker
Steven Parker
167,921 Points

You're close, but don't duplicate any code. The instructions just want the existing code converted into a function.

Dolapo Sekoni
PRO
Dolapo Sekoni
Pro Student 1,431 Points

thanks for your response. could you kindly pin point to a code i duplicated. couldn't figure it out. am new to programming

Steven Parker
Steven Parker
167,921 Points

It's probably easiest to start the challenge fresh. Then you only need to add one new line to define the main function. After that you just increase the indent on the lines already there so they will be considered part of that function.

Craig Dennis
Craig Dennis
Treehouse Teacher

I noticed your While is uppercased..that is a keyword and should be all lowercase.

What errors are you getting?

Dolapo Sekoni
PRO
Dolapo Sekoni
Pro Student 1,431 Points

def Main():

show_help()

    # make a list to hold unto our items
    shopping_list = []

While True:
    # ask for new items
    new_items = ("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

    show_list(shopping_list)



Hello Steven, thanks for your time. i started all over and am still stucked. i def the main function and put 4 spaces in front of all codes after it and still wont fly....
Dolapo Sekoni
PRO
Dolapo Sekoni
Pro Student 1,431 Points

def Main():

show_help()

    # make a list to hold unto our items
    shopping_list = []

While True:
    # ask for new items
    new_items = ("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)
Steven Parker
Steven Parker
167,921 Points

Don't forget to fix the spelling of "while" as Craig suggested. I was thinking if you started over this wouldn't be an issue.