Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Juner Pagal
Juner Pagal
11,968 Points
Posted by Juner Pagal
Juner Pagal
11,968 Points

Here is the link of the question. https://teamtreehouse.com/library/jquery-basics/creating-a-simple-lightbox/adding-new

Just wanna ask what is wrong of my answer below. If you have the correct answer of this test please share it. thank you.

$(".external a").click(function(event) { event.preventDefault(); this.attr("target","_blank"); });

js/app.js
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

2 Answers

Roberto Correale
Roberto Correale
1,539 Points
Roberto Correale
Roberto Correale
1,539 Points

The link you've provided to the question is not working.

Anyway, the first problem is with jQuery. If you look at the console in developer tools you will find an error saying $ is not defined. For solving this you need to add "http:" before "//code.jquery.com/jquery-1.11.0.min.js" or use a cdn like <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js"></script>

Second things the selector is wrong, and you need to use the jquery selector for using this. 

$("a.external").click(function(event) { 
    event.preventDefault(); 
    $(this).attr("target","_blank"); 
});
Juner Pagal
Juner Pagal
11,968 Points
Juner Pagal
Juner Pagal
11,968 Points

Thanks for giving the answer below.

$(".external").attr("target","_blank");