Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Sean Modd
Sean Modd
4,688 Points

Here is what I'm getting - I've copied and pasted it onto CodePen please help!! https://codepen.io/seanmodd/pen/LYNrvdZ

I'm not sure what I'm missing - I'm just very confused and can't figure out the issue I'm having here!

js/app.js 
const listItems = document.querySelectorAll('.rainbow');


var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(let i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

3 Answers

Sakib Ahmed
Sakib Ahmed
10,105 Points

You are not querying the correct selector. The ul is an ID so you need to us # not . See below:

document.querySelectorAll('#rainbow li');
Sean Modd
Sean Modd
4,688 Points
Sean Modd
Sean Modd
4,688 Points

Here is my updated version but still getting it wrong!

const listItems = document.querySelectorAll('[ul=rainbow]');


var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(let i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
Sean Modd
Sean Modd
4,688 Points
Sean Modd
Sean Modd
4,688 Points

Amazing thank you so much Sakib Ahmed