Welcome to the Treehouse Community
The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Andrew Matimba
10,255 PointsHi, Can someone help me here,
I am see nothing wrong with this code. Let's practice using @classmethod! Create a class method in Letter named from_string that takes a string like "dash-dot" and creates an instance with the correct pattern (['_', '.']).
class Letter:
def __init__(self, pattern=None):
self.pattern = pattern
def __iter__(self):
yield from self.pattern
def __str__(self):
output = []
for blip in self:
if blip == '.':
output.append('dot')
else:
output.append('dash')
return '-'.join(output)
@classmethod
def from_string(cls, my_string):
my_list = my_string.split("-")
output = []
for element in my_list:
if element == "dash":
output.append("-")
else:
output.append(".")
return cls(output)
class S(Letter):
def __init__(self):
pattern = ['.', '.', '.']
super().__init__(pattern)
1 Answer

Branden Ciranni
8,747 Pointsin your from_string()
method, you have
output.append("-")
It took me a few minutes to spot it, and I'm pretty sure I did the same thing when I did this question, but if you reread the question, the challenge wants the output with an underscore, not a dash. Changing it to
output.append("_")
worked for me.
Andrew Matimba
10,255 PointsAndrew Matimba
10,255 PointsChanged that but still not working
Branden Ciranni
8,747 PointsBranden Ciranni
8,747 PointsYou have an issue with indentation. It looks like you added a space by accident in the following line
pattern = ['.', '.', '.']
in the
S
class. Backspace to line it all up properly and it should work. To find this, I recommend copying and pasting code that you have problems with into an IDE like PyCharm. It will spot these indentation mistakes for you.Perfect Tinotenda Mashingaidze
5,070 PointsPerfect Tinotenda Mashingaidze
5,070 Pointsit worked thankx