Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Posted by Yuri Brutsky
Yuri Brutsky
9,943 Points

Hmm, didn't get the right movement results.

I don't get it, it seems like a right answer when I run it on the workspace, but I am still missing something

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    if direction == (1, 0):
        if x == 9:
            hp -= 5
        else:
            x += 1
    elif direction == (-1, 0):
        if x == 0:
            hp -= 5
        else:
            x = -1
    elif direction == (0, 1):
        if y == 9:
            hp -= 5
        else:
            y += 1
    elif direction == (0, -1):
        if y == 0:
            hp -= 5
        else:
            y -= 1
    return x, y, hp

1 Answer

Steven Parker
Steven Parker
227,167 Points
Steven Parker
Steven Parker
227,167 Points

Even though the examples show only movement of one unit in one direction, it's possible that the direction might be changed in both directions at once, or that the movement might be more than one unit at a time.

Try revising your strategy to accommodate both of these possibilities and I'll bet you'll pass. Give it a little thought, and you can also make the entire function more compact, too.

Yuri Brutsky
Yuri Brutsky
9,943 Points

thanks, I really didn't think about that. I made it more universal and it worked