How about making a new test that does the same, Arrange, Act and Assert named refundingResetsAvailableFundsToZero that s

Question

Ive been changing the @Test method multiple times the previous video didnt show a lot of insight for me how to make the solution im still quite new in Java.

com/teamtreehouse/vending/CreditorTest.java

package com.teamtreehouse.vending;

import org.junit.Test;

import static org.junit.Assert.*;

public class CreditorTest {

    @Test
    public void addingFundsIncrementsAvailableFunds() throws Exception {
        Creditor creditor = new Creditor();

        creditor.addFunds(25);
        creditor.addFunds(25);

        assertEquals(50, creditor.getAvailableFunds());
    }

    @Test
    public void refundingReturnsAllAvailableFunds() throws Exception {
        Creditor creditor = new Creditor();
        creditor.addFunds(10);

        int refund = creditor.refund();

        assertEquals(10, refund);
        assertEquals(0, creditor.getAvailableFunds());
    }
}
  @Test
    public void refundingReturnsAllAvailableFundsToZero() throws Exception {
        Creditor creditor = new Creditor();
        creditor.addFunds(0);

        int refund = creditor.refund();

        assertEquals(0, refund);
        assertEquals(0, creditor.getAvailableFundsToZero());
    }
}

com/teamtreehouse/vending/Creditor.java

package com.teamtreehouse.vending;

public class Creditor {
    private int funds;

    public Creditor() {
        funds = 0;
    }

    public void addFunds(int money) {
        funds += money;
    }

    public void deduct(int money) throws NotEnoughFundsException {
        if (money > funds) {
            throw new NotEnoughFundsException();
        }
        funds -= money;
    }

    public int refund() {
        int refund = funds;
        funds = 0;
        return refund;
    }

    public int getAvailableFunds() {
        return funds;
    }

}

Answer 1 · 2016-10-03T13:11:53Z

October 3, 2016 1:11pm

First of all there is no getAvailableFundsToZero() method in Creditor class...

        assertEquals(0, creditor.getAvailableFundsToZero()); // no such method exists

There is only getAvailableFunds() function

Second, all you need to do is to move asserting line

 assertEquals(0, creditor.getAvailableFunds());

refundingReturnsAllAvailableFunds() into to the new test.

This way we'll make one assertion per test if possible as Craig wants

In your test there are still two assertions.

Let me write you a hint with sudo code:

    @Test
    public void refundingReturnsAllAvailableFundsToZero() throws Exception {
        Creditor creditor = new Creditor(); // correct
        creditor.addFunds(0); // correct

        int refund = creditor.refund(); // correct

        // wrong, because we already asserted it,we want  one assertion per test
        assertEquals(0, refund); 
        // change name of the method, it is wrong, see above
        assertEquals(0, creditor.getAvailableFundsToZero()); 
    }

Welcome to the Treehouse Community

Looking to learn something new?

Ricard Taujenis

Ricard Taujenis

How about making a new test that does the same, Arrange, Act and Assert named refundingResetsAvailableFundsToZero that s

1 Answer

Alexander Nikiforov

Alexander Nikiforov

Ricard Taujenis

Ricard Taujenis

Alexander Nikiforov

Alexander Nikiforov