How do I call all cities in one line?

Question

Great WS, straight forward and easy to follow. 
How do I call all cities without calling one by one?
```JavaScript
var City = function(name, state) {
    this.name = name || 'Portland';
    this.state = state || 'Oregon';
    this.printMyCityAndState = function() {
      console.log("My city is " + this.name + ", and my state is " + this.state);
    };
};
portland = new City();
seattle = new City('Seattle', 'Washington');
salem = new City('Salem');
vancouver = new City('Vancouver', 'Washington');
portland.printMyCityAndState();
seattle.printMyCityAndState();
salem.printMyCityAndState();
vancouver.printMyCityAndState();
```

Chris Shaw · Accepted Answer

Hi @johnnyesper (https://teamtreehouse.com/johnnyesper),
You can store each City instance within an array and/or object and then iterate over it as shown below.
Using an array
```js
var cities = [
  new City(),
  new City('Seattle', 'Washington'),
  new City('Salem'),
  new City('Vancouver', 'Washington')
];
for (var c in cities) {
  // c = numeric array id
  // cities[c] = City instance
  cities[c].printMyCityAndState();
}
```
Using an object (if you want key/value pairs for quicker identification)
```js
var cities = {
  portland: new City(),
  seattle: new City('Seattle', 'Washington'),
  salem: new City('Salem'),
  vancouver: new City('Vancouver', 'Washington')
};
for (var c in cities) {
  // c = key (city name)
  // cities[c] = City instance
  cities[c].printMyCityAndState();
}
```
Happy coding!

johnnyesper · Answer

Thanks

Matthew Smart · Answer

A bit of code would help, it means we don't haver to watch the whole video to figure out what you mean

Welcome to the Treehouse Community

Looking to learn something new?

johnnyesper

johnnyesper

How do I call all cities in one line?

3 Answers

Chris Shaw

Chris Shaw

Using an array

Using an object (if you want key/value pairs for quicker identification)

Matthew Smart

Matthew Smart

johnnyesper

johnnyesper

johnnyesper

johnnyesper