How do I finish my Hangman game?

Hey Marina at work but I'll look at this when I arrive home.

For the shown code, I assume after you updated it :

The game is not ended upon winning because you're not checking if someone has won until after getRemainingTries = 0.

Another way of saying this is that you aren't exiting the while loop until someone has already lost, so you'll want to put your haveWon check inside the while loop.

Edit : I noticed putting this check in the while loop is what Rob had in his post earlier as well

Hey Maria,

I loaded up your code in my IDE and worked through it, The first thing I noticed is that we're comparing mGame.haveWon() to a int value, normally this wouldn't compile, but because in java both 0 and 1 can be converted to an boolean value (0 being false, so every time it's true that the player has not won yet it will think that the code compiles and runs it, an awkard bug, and one I didn't notice when first looking at this)

I fixed that that and it put it in the same loop that you can, so I had to check to make sure that the logic was good, and I adjusted the code a bit, instead of making sure that the same amount of hits are the same as the length of the answer, (it looks like it was only count two hits in letters that had multiple repeats, I changed the logic check to below

public boolean haveWon() { //This is my failed attempt at showing the user that they won.. :-(
        boolean winner = false;
        if (getCurrentProgress().equals(mAnswer)) {
            winner = true;
            System.out.printf("YAAAY, YOU WON!");
            System.exit(0);
        }
        return winner;
    }

So that instead what this is doing is checking to make sure that when comparing the string that is returned from your get current progress has to match the mAnswer exactly.

Your code was good, and it would work for most time, but I think some words were tripping it up. After I toyed around with that method I just called the play method like this

public  void play() {
        while (mGame.getRemainingTries() > 0) {
            displayProgress();
            promptForGuess();
            mGame.haveWon();
        }
        if (mGame.getRemainingTries() == 0) {
            System.out.printf("YOU LOST! :-(\n");
            System.exit(0);
        }
    }

Which seems to work okay and passes the few test cases I give it, I think the only thing that needed to be changed was the logic, which looked good to begin with, but probably just led to bugs after multiple use. When we're comparing any type of strings together == can give false postives, and .equals is a much more reliable method.

Thanks, let me know if I didn't explain this well enough and what parts are a still a bit murky, and I'll see if I can give it a better second chance.

Still, a very good job at a first project.