Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Kaisha Jones
Kaisha Jones
6,366 Points
Posted by Kaisha Jones
Kaisha Jones
6,366 Points

How do I select all the <li> tags within a <ul> tag, that's nested in a <nav> tag?

Do I treat it as an array with an object? Iterate over it as an array? Feedback and clarity would be greatly appreciated.

js/app.js 
let navigationLinks = document.getElementsByTagName('nav')[0];

let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
Joseph O'Reilly
Joseph O'Reilly
4,689 Points
Joseph O'Reilly
Joseph O'Reilly
4,689 Points

Hey Nick,

I had a play around and when you grab the content, unfortunately it returns an HTML Collection, not an array.

So to get around this, there is a method called Array.from(), which I used to return an array of all the li tags.

From there, you can create a new array, with the slice method to get the first li tags from the first Nav section and from here you can iterate over like an normal array.

Don't know if this is the best way, but it will get you some where :) I've added my code below as an example:

let navigationLinks = Array.from(document.getElementsByTagName('li'));

let galleryLinks; let footerImages;

const firstLi = navigationLinks.slice(0,3)

console.log(firstLi);

for(i = 0; i < firstLi.length; i++) { console.log(firstLi[i].textContent);

}

Cheers

Joe

1 Answer

walter palma
walter palma
3,189 Points
walter palma
walter palma
3,189 Points

The challenge asks you for the links withing the "nav" tag, so I think you are confusing links that is an "a" tag with "li", just because "li" is resembles links.

But in order to do what you asked you would write:

let navigationLinks = document.querySelectorAll("nav ul li")

and for the challenge:

let navigationLinks = document.querySelectorAll("nav a")