JavaScript JavaScript and the DOM Getting a Handle on the DOM Practice Selecting Elements

Alasdair Marchant
Alasdair Marchant
4,592 Points

How do I select the descendent correctly

I have used the following code but am getting the error that I am selecting 0 link elements.

let navigationLinks;
let galleryLinks;
let footerImages;

navigationLinks = document.getElementsByTagName('nav a');
<!DOCTYPE html>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
    <div id="wrapper">
        <ul id="gallery">
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
        <a href=""><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href=""><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
  <script src="js/app.js"></script>

1 Answer

Justin Horner
Justin Horner
Treehouse Guest Teacher

Hello Alasdair,

You're very close to passing this challenge. Your query is correct, but the function should change.

You're currently using getElementsByTagName, which does not handle CSS queries. It will only get the elements in the document with the specified tag name, like "li".

To select multiple elements using a CSS query, you'll want to use either querySelector or querySelectorAll. In this case, we want all the elements that match our query, so changing your function to querySelectorAll should pass the challenge.

I hope this helps.