Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge

Edwin Carbajal
Edwin Carbajal
4,133 Points
Posted by Edwin Carbajal
Edwin Carbajal
4,133 Points

How I refactored

var html = '';
var red;
var green;
var blue;
var rgbColor;

function randomColor() {
  return Math.floor(Math.random() * 256 );
}

for (var i = 0; i < 10; i++) {
  red = randomColor();
  green = randomColor();
  blue = randomColor();

  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

document.write(html);

2 Answers

Steven Parker
Steven Parker
229,745 Points
Steven Parker
Steven Parker
229,745 Points

Good job! :+1:

Your solution has many of the elements of the one Dave shows in the second solution video.

Ryan Mayo
Ryan Mayo
23,604 Points
Ryan Mayo
Ryan Mayo
23,604 Points

Nice! The next step might be to remove the color variables entirely and just call the function directly in the html variable assigning like: html += '<div style="background-color:rgb(' + randomColor() + ',' + randomColor() + ',' + randomColor() + ');" ></div>'; See if you can get the whole thing down to 8 lines..