Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python

Gokul Nishanth
PLUS
Gokul Nishanth
Courses Plus Student 581 Points

How to finish this challenge?

And, finally, if I have doubles, I want to reroll the hand. Add a classmethod to CapitalismHand named reroll that returns a new instance of the class, effectively rerolling the hand.

hands.py
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self):
        super().__init__(size=2, die_class=D6)

    @property
    def doubles(self):
        if len(self._by_value(1)) == 2:
            reroll()
        if len(self._by_value(2)) == 2:
            reroll()
        if len(self._by_value(3)) == 2:
            reroll()
        if len(self._by_value(4)) == 2:
            reroll()
        if len(self._by_value(5)) == 2:
            reroll()
        if len(self._by_value(6)) == 2:
            reroll()
        else:
            return False 

    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

    def reroll(self):
        ch = CapitalismHand()
        return ch

6 Answers

Hey Gokul,

I was having trouble with this one as well. Your reroll() method works perfectly, but you need to add the @classmethod above it. Additionally, I would consider refactoring your doubles() method, as the challenge never asked us to call this method in the event that we get doubles, and I wonder if it may be affecting your results. Since a Hand is a list of two objects, all you have to do is compare them to each other to get a True or False.

Murat Mermerkaya
Murat Mermerkaya
2,346 Points

I did like your comment but still not working:

from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice



class CapitalismHand(Hand):
    def __init__(self):
        super().__init__(size=2, die_class=D6)

    @property
    def doubles(self):
        if self[0] == self[1]:
            True


    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

[MOD: added ```python formatting -cf]

Chris Freeman
Chris Freeman
Treehouse Moderator 67,986 Points

Specifically, by using reroll() within the doubles() method it will raise an error since "reroll()" is not defined. Properly, it would be self.reroll(). But refactoring is the better approach. You can directly compare the values of the two die using :

self[0].value == self[1].value

Hello Kurt, why you saying "as the challenge never asked us to call this method in the event that we get doubles" - the challenge is specifically asking - "And, finally, IF I HAVE DOUBLES, I want to reroll the hand.".... it asks in the case of double only then reroll the hand...

Erika Suzuki
Erika Suzuki
20,299 Points

Coming from Java. This is by far the hardest OOP lesson I ever studied.

Benyam Ephrem
Benyam Ephrem
16,505 Points

Hahahaahahaha, same here. Went from Java to JS and it was a breeze but this is certainly challenging. But I guess it is the same as with anything new you learn. Over time it becomes natural

Chris Freeman
Chris Freeman
Treehouse Moderator 67,986 Points

Benyam, I hope you mean "over time" vs "overtime". Though "Overtime: it becomes natural" is not an inaccurate statement! ?

Benyam Ephrem
Benyam Ephrem
16,505 Points

I apologize...I've been coding overtime over time so my fingers are typing faster than my brain can think. Corrected it :)

Khaleel Yusuf
Khaleel Yusuf
15,208 Points

I copied and pasted Murat Mermerkaya and fixed the mistake but I said: "Try again"

Khaleel Yusuf
Khaleel Yusuf
15,208 Points

I meant Murat Mermerkaya's code