Python Object-Oriented Python Dice Roller RPG Roller

Jerry Avila
Jerry Avila
Python Development Techdegree Student 5,523 Points

I am not sure what is wrong with my code

Stuck on this challenge not sure what is wrong with the code.

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py
from dice import D20

class Hand(list):
    def __init__(self, die_class=None, *args, **kwargs):
        if not die_class:
             raise ValueError("You must provide a die class")
        super().__init__()


    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, self, die_class =D20):
        self = cls()
        for _ in range():
            dice.append(die_class())
        return cls(self)

1 Answer

Steven Parker
Steven Parker
202,104 Points

A few things stand out at first glance:

  • "self" won't be passed to a class method (your next line makes one using cls)
  • append the die to "self" instead of "dice"
  • "self" is already an instance, just return it without calling "cls" again

UPDATE: Something I didn't notice the first time is that you added an override of "init" which changes the calling signature (and prevents it from working as expected by the challenge).

You don't need an override at all here.

Jerry Avila
Jerry Avila
Python Development Techdegree Student 5,523 Points

I think I made all the changes and still getting Bummer try again. noticed that the size for number of dice was missing so added that but still not working: from dice import D20

class Hand(list): def init(self,size=0, die_class=None, *args, **kwargs): if not die_class: raise ValueError("You must provide a die class") super().init()

@classmethod
def roll(cls, size=2, die_class =D20):
    self = cls()
    for _ in range(size):
        self.append(die_class())
    return self

@property
def total(self):
    return sum(self)