Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Inheritance Super!

Jordon Crichton
Jordon Crichton
1,868 Points

I am unsure whether I should create a new method under SortedInventory or attached list.sort on to the add_item method.

Sorted inventories should be just that: sorted. Right now, we just add an item onto the slots list whenever our add_item method is called. Use the list.sort() method to make sure the slots list gets sorted after an item is added. Only do this in the SortedInventory class.

inventory.py
class Inventory:
    def __init__(self):
        self.slots = []

    def add_item(self, item):
        self.slots.append(item)

class SortedInventory(Inventory):
    def add_item(self,item):
        super().add_item(item)
        self.slots.append(item)
        self.slots.sort()

2 Answers

Steven Parker
Steven Parker
229,732 Points

This should be part of the development of the "add_item" method. If you were being instructed to add a new method, It would have said so explicitly and the name to give it would have been included.

And remember the other instruction: "Only do this in the SortedInventory class."

Jordon Crichton
Jordon Crichton
1,868 Points

Thank you, can you tell me why my code above does not sort the list?

Steven Parker
Steven Parker
229,732 Points

This code does sort the list. But it has an issue with item duplication.

The "super().add_item(item) line adds the item using the base class method, but then "self.slots.append(item) adds it again. That second line isn't needed and should be removed.