Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Scrabble Tiles

I can't find the error in the hasTile method,

I need to return true if the char tile is in tiles string, and false if not. Can't find the mistake

ScrabblePlayer.java
public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    // TODO: Add the tile to tiles

    tiles += tile;

  }

  public boolean hasTile(char tile) {
    // TODO: Determine if user has the tile passed in

    if(tiles.indexOf(tile) <= -1) {

      return false;

    }

    if(tiles.indexOf(tile) >= 0) {

     return true;

    }



  }

}

2 Answers

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! You have the right idea, but the challenge wants you to return the result of the expression directly. Instead, you are doing two separate evaluations and then returning a true or false based on this. It's generally considered to be much cleaner code to avoid a situation where you have something like "if x is true return true otherwise return false".

Here's the line you're looking for:

return tiles.indexOf(tile) >= 0;

This asks if the index of the tile is greater or equal to 0. If this is true, then the tile is present in the tiles string. So this line essentially says "is the tile in the string?" and will return a true or false accordingly.

Hope this helps! :sparkles:

Thank you very much!