Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

kabir k
PLUS
kabir k
Courses Plus Student 18,036 Points
Posted by kabir k
kabir k
Courses Plus Student 18,036 Points

I can't preview Refactoring Loop part 2

Up till topic I have been able to preview the code as I follow the intructor along in the workspace but for some reason, when I try to preview the code in this section, the page just goes blank.

Can someone point out what's wrong with this code or why it's not showing the the preview page.

Here's the code:

var html = '';
var rgbColor;

function randomRGB() {
  return Math.floor(Math.random * 256);
}

function randomColor() {
  var color = 'rgb(';
  color += randomRGB() + ',';
  color += randomRGB() + ',';
  color += randomRGB() + ')';
  return color;
}

function print(message) {
  document.write(message);
}

for (var i = 0; i < 10; i += 1) {
  rgbColor = randomColor();
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

print(html);

1 Answer

Marcus Parsons
Marcus Parsons
15,719 Points

Hey Kabir,

You are missing a () beside Math.random in your randomRGB function. Also, for those div's to show up, you need to have some content in between the div tags or just assign at least a height to the divs. I would use the latter option:

var html = '';
var rgbColor;

function randomRGB() {
  //added () to Math.random so that it will be called
  return Math.floor(Math.random() * 256);
}

function randomColor() {
  var color = 'rgb(';
  color += randomRGB() + ',';
  color += randomRGB() + ',';
  color += randomRGB() + ')';
  return color;
}

function print(message) {
  document.write(message);
}


for (var i = 0; i < 10; i += 1) {
  rgbColor = randomColor();
  //change width and height to whatever you'd like
  html += '<div style="width:50px;height:50px;background-color:' + rgbColor + '"></div>';
}

print(html);
kabir k
kabir k
Courses Plus Student 18,036 Points
kabir k
kabir k
Courses Plus Student 18,036 Points

Thanks, Marcus. I couldn't just see the missing pair of parentheses. The extra styling doesn't seem to have much effect in this case.

Marcus Parsons
Marcus Parsons
15,719 Points

The divs will not show up unless you give them at least a height value or put content in between the tags.