Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Arielle Foldoe
Arielle Foldoe
8,132 Points
Posted by Arielle Foldoe
Arielle Foldoe
8,132 Points

I do not understand what value I am supposed to assign the attribute.

It keeps saying the it expects 'target' to hold the value '_blank' not ''. I've tried entering it as a variable and a string. I think I'm misunderstanding the question.

js/app.js 
var _blank = "_blank";

$(".external a").attr("target", _blank);
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

2 Answers

Matthias J.
Matthias J.
20,355 Points
Matthias J.
Matthias J.
20,355 Points

the only mistake you are making here is that you select with 

     $(".external a")

with this you would select all links in an element with the class external.

but the challenge says that you have to select all links WITH the class "external" so you select it like this

     $(".external")

the whole line would look like this :)

$(".external").attr("target", "_blank");

no need for an extra variable :)

Arielle Foldoe
Arielle Foldoe
8,132 Points
Arielle Foldoe
Arielle Foldoe
8,132 Points

I feel slightly silly now, but I suppose that's a part of learning new things lolz. Thanks so much!