Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Constantine Thompson
Constantine Thompson
6,628 Points
Posted by Constantine Thompson
Constantine Thompson
6,628 Points

I don't know what I'm missing...

$(document).ready(function(){ $('#external a').attr('target', '_blank'); });

js/app.js 
$(document).ready(function(){
  $('#external a').attr('target', '_blank');
});
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

3 Answers

Seth Kroger
Seth Kroger
56,413 Points
Seth Kroger
Seth Kroger
56,413 Points

The # is for selecting by id's. If you're selecting a class it's the dot (.) you need to use:

$(document).ready(function(){
  $('a.external').attr('target', '_blank');
});
Anastasia Lanz
Anastasia Lanz
9,399 Points
Anastasia Lanz
Anastasia Lanz
9,399 Points

Hi there,

You need to select the class "external". Right now you are trying to select an id of "external".

$(".external").attr( "target", "_blank" );
Constantine Thompson
Constantine Thompson
6,628 Points
Constantine Thompson
Constantine Thompson
6,628 Points

Thanks guys... I noticed that right after posting my question. I appreciate the quick response!!