Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

I dont see why my selector wouldn't work here. Please give me a hint I am stuck.

how can I make this work?

var listItems = document.getElementById('#rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
<!DOCTYPE html>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    <script src="js/app.js"></script>

2 Answers

Zack Jackson
Zack Jackson
30,220 Points

Josephine Höltermann I just updated my response. You need to grab the individual li elems not the ul.

ah thanks I see! the devil is in the detail!

Zack Jackson
Zack Jackson
30,220 Points

You don't need the # in your selector. Just wrap the id in quotes.

The next thing is that with your id selector, you are selecting the ul, not each li. So your selector should chain onto the end something like .getElementsByTagName("li"); to get each li element.

that would still not solve the problem unfortunately. I think I have to tell 'it' that I want all <ul> elements that are children of the list with id rainbow but I can't see how I would do that. I am fairly new to Javascript.