JavaScript JavaScript and the DOM Getting a Handle on the DOM Practice Selecting Elements

Tim Rothauer
Tim Rothauer
2,425 Points

I don't understand why I am not selecting all the elements in <nav> with document.getElementsByTagName("nav");

Please help! Thanks!

let navigationLinks = [document.getElementsByTagName("nav")];  
let galleryLinks;
let footerImages;
<!DOCTYPE html>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
    <div id="wrapper">
        <ul id="gallery">
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
        <a href=""><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href=""><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
  <script src="js/app.js"></script>

1 Answer

54,285 Points

With document.getElementsByTagName("nav") you are selecting a collection of nav elements. If you want to select the links within the nav element you can follow the hint provided in the challenge where it is suggested to use querySelectorAll() along with a descendant selector.

From the teacher's notes in the hint:

To create a descendant selector, we’ll need to use two or more selectors separated by whitespace:

ul li {
  margin-bottom: 12px;

The above example selects all <li> elements inside <ul> elements.

In the challenge you will want to select all <a> elements inside <nav> elements.