JavaScript JavaScript and the DOM Getting a Handle on the DOM Selecting Multiple Elements

shay elbaz
shay elbaz
2,885 Points

I don't understand why this code is not running it looks ok to me? please help me understand?

As you see i wrote everything fine.

index.html
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js
let listItems = document.getElementById('rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];


for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

2 Answers

shay elbaz
shay elbaz
2,885 Points

I was doing : document.getElementByTagName('li'); And its worked... Tnx!

Adam Pengh
Adam Pengh
28,838 Points

You're selecting the <ul> element and not all of the <li> elements.

let listItems = document.querySelectorAll('ul#rainbow > li');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}