Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Validating and Normalizing User Input

Zachary Martin
Zachary Martin
3,545 Points
Posted by Zachary Martin
Zachary Martin
3,545 Points

I followed along with normalized input and my code compiled but it still doesn't actually normalize uppercase letters.

I don't know what I did wrong so ill ost my code

Zachary Martin
Zachary Martin
3,545 Points
Zachary Martin
Zachary Martin
3,545 Points

This is the game logic where I believe the error is class Game { public static final int MAX_MISSES =7; private String answer; private String hits; private String misses;

public Game(String answer){

this.answer = answer.toLowerCase(); hits = ""; misses="";
}

private char normalizedGuess(char letter) { if(!Character.isLetter(letter)) { throw new IllegalArgumentException("A letter is required");

}

letter = Character.toLowerCase(letter); if(misses.indexOf(letter)!= -1 || hits.indexOf(letter)!= -1) { throw new IllegalArgumentException (letter + " has already been guessed"); } return letter; }

public boolean applyGuess(char letter) { boolean isHit = answer.indexOf(letter)!= -1;

letter = normalizedGuess(letter);

if(isHit){
  hits += letter;
} else {
misses += letter;

} return isHit;

}
public String getCurrentProgress(){ String progress = ""; for(char letter : answer.toCharArray()){ char display = '-'; if(hits.indexOf(letter)!=-1) { display = letter; } progress += display;

}
return progress;

} public int getRemainingTries(){ return MAX_MISSES - misses.length(); }

}

1 Answer

Tracy Chacon
Tracy Chacon
7,372 Points
Tracy Chacon
Tracy Chacon
7,372 Points

Common logic error: Because you need to validate/normalize the letter (change toLowerCase) with

letter = normalizeGuess(letter);

before you make sure that you have a hit with

boolean isHit = answer.indexOf(letter) != -1;

IN

public boolean applyGuess(char letter){ 
    letter = normalizeGuess(letter);
    boolean isHit = answer.indexOf(letter) != -1;
    if(isHit)
    {
      hits += letter;
    }
    else
    {
      misses += letter;
    }
    return isHit;
  }

SHOULD BE:

letter = normalizeGuess(letter);
boolean isHit = answer.indexOf(letter) != -1;

AND NOT:

 boolean isHit = answer.indexOf(letter) != -1;
 letter = normalizeGuess(letter);