Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Posted by Marco Koopman
Marco Koopman
5,290 Points

I get the results from the example but it says it's not right.

Hey!

If you check my code it gives the same result as the example in the code yet I get a Bummer message.

Does anybody know what mistake I made?

Cheers!

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
  x, y, hp = player
  xd, yd = direction

  if x == 0 and xd == -1:
    hp -= 5
    x = 0 
  if x == 9 and xd == 1:
    hp -= 5
    x = 9
  if y == 0 and yd == -1:
    hp -= 5
    y = 0
  if y == 9 and yd == 1:
    hp -= 5
    y = 9

  return x, y, hp

1 Answer

Alexander Davison
Alexander Davison
65,469 Points
Alexander Davison
Alexander Davison
65,469 Points

You forgot to actually move the player if the player isn't going into a wall.

def move(player, direction):
    x, y, hp = player
    xd, yd = direction
    if x == 0 and xd == -1:
        hp -= 5
    elif x == 9 and xd == 1:
        hp -= 5
    elif y == 0 and yd == -1:
        hp -= 5
    elif y == 9 and yd == 1:
        hp -= 5
    else:
        x, y = x + xd, y + yd
    return x, y, hp