Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Counting Scrabble Tiles

i give up on this exercise

what's wrong with this code

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;
    public int count;
  public ScrabblePlayer() {
    tiles = "";

  public String getTiles() {
    return tiles;

  public void addTile(char tile) {
    tiles += tile;

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;

  public int getCountOfLetter(char letter) {
    for(char player1: tiles.toCharArray())
     if (tiles.indexOf(tiles) == letter) {
      count++; } 

    return count;
// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();

    ScrabblePlayer player2 = new ScrabblePlayer();

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');

2 Answers

Hi. There are a few issues here.

Regarding your for-each loop:

for(char player1: tiles.toCharArray())

This reads as "For each player1 char in the char array made from the tiles String". Then you're not using that player1 variable anywhere in the method. The statement is correct but remember to use descriptive names for your variables. So as the char here is essentially a tile (not a person), why not just name it "tile".

for (char tile : tiles.toCharArray())

which reads "for each tile in the array of tiles"

The second issue is here:

if (tiles.indexOf(tiles) == letter)

You're saying: "if the index (which is an int) of the String tiles in the String tiles is equal to the char letter". I think you will agree that the first part of your statement does not make much sense and you're comparing an int to a char. Here, we want to check if the tile from our previous for-each loop is equal to the letter we're passing in, in which case, we increase the count by 1, as you did correctly (count++). So:

if (tile == letter) {
    count ++

Here, we're comparing 2 chars.

Then you return the count, as you did. The whole method reads: "For each tile in the tiles array, if the tile is equal to the letter, we increase the count by 1 and then we return the final count once we've checked all the tiles in the array."

Hope that helps :)

thank you it worked!!!

You're welcome! Glad I could help :)