Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Buster Siem
Buster Siem
7,280 Points

I have no clue, how I should fix this code challenge - how do I cycle through the colours?

I don't really know if it's because my code needs to "cycle" the colors-list, or if it's something else. If this is the case, I am having a bit of a hard time fixing that piece of code in the for-loop. Oh, and the list in the preview just turns all <ul>-items red... yikes.

js/app.js 
let listItems = document.querySelectorAll("ul");
let colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for (let i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Zimri Leijen
Zimri Leijen
11,835 Points
Zimri Leijen
Zimri Leijen
11,835 Points

i++ should be without a space.

also, you should select the list items, not the list container.

Buster Siem
Buster Siem
7,280 Points

So, this - for your own information - is not correct, you can always leave the i ++ in the for-loop with or without a space. The problem was the you need to note the .children-element of the color-array.

Zimri Leijen
Zimri Leijen
11,835 Points

actually using 'li' instead of 'ul' would have worked, but the space does indeed not matter. Still looks better though.