I interpreted the challenge differently. How can I make this code DRY?

Question

let quiz = [
   ["Who is the president of the United States?", 
   "How many states are in the US?", 
   "What is the capital of California?", 
   "Name the ocean on the west coast.", 
   "Name the country north of the US.", 
   "How many colors are in the US flag?"], 

   ["Biden", '50', "Sacramento", "Pacific", "Canada", '3']
];

let counter = 0

for (let i = 0; i < quiz[0].length; i++) {
    let answer = prompt(quiz[0][i]);
    if (answer === quiz[1][0]) {
    counter++};  
    if (answer === quiz[1][1]) {
    counter++};  
    if (answer === quiz[1][2]) {
    counter++};
    if (answer === quiz[1][3]) {
    counter++};
    if (answer === quiz[1][4]) {
    counter++};
    if (answer === quiz[1][5]) {
    counter++};
    if (answer === quiz[1][6]) {
    counter++};
    if (answer === quiz[1][7]) {
    counter++}; 
};

console.log(counter);

document.querySelector('main').innerHTML = `<h1>Out of 6, you got ${counter} questions correct.</h1>`

Answer 1 · 2022-03-25T18:04:13Z

March 25, 2022 6:04pm

Being "DRY" isn't the biggest issue here, there is a basic logic problem. To illustrate the problem, try giving the same answer (like "50") to every question and the program will consider them all correct. You'll want to adjust the checking strategy to make sure only the correct answer for each question is counted. Eliminating the redundant checks will also make the code more "DRY" at the same time. For example:

for (let i = 0; i < quiz[0].length; i++) {
    let answer = prompt(quiz[0][i]);
    if (answer === quiz[1][i]) {    // check ONLY this question's answer
        counter++;
    }
};

Welcome to the Treehouse Community

Looking to learn something new?

Hina K.

Hina K.

I interpreted the challenge differently. How can I make this code DRY?

1 Answer

Steven Parker

Steven Parker