Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
mrx3
8,742 PointsI made a website on code pen, and I have a couple of questions about my CSS.
I'll paste my codepen link below. The first question I have about my CSS start on line 188-194. I put the href attributes inside of a div and centered them. Is it okay that I did the center align like that? I was thinking about maybe using display: inline or something similar.
My next question concerns lines 201-217. I decided to use the
a[href^="#"]
because, I wanted to style all three links in one shot, and this seemed to be a good way/time to use that. Is the way I styled the hrefs correct. Online 212 I used the :target because I wanted to add a cool background, and change the color of the text.
This site has been set up for different sized browser windows so, reduce your screen size and the site will change. The only thing I didn't style for mobile yet is the href font sizes...it's been a long day at work, and I'm tired :). The font size is a little small when going to a really small screen but, I have a phone that is really small, and the text does look like that on my phone when I surf the net on it. Thank you so much for any feedback, I really appreciate it.
Codepen: http://codepen.io/mike316/pen/xbVbgb
mrx3
8,742 PointsThe color is a joke. I just slapped the site together for practice. I have a image background but, I don't know how to add it to codepen. Thanks for the input Marcus.
Marcus Parsons
15,719 PointsYou could upload it to Imgur and then use the "Direct Link" to use it as a background. No problem!
Marcus Parsons
15,719 PointsMarcus Parsons
15,719 PointsAs far as the CSS goes, everything works fine, and you did it the way you wanted to do it, which is fine, too. There are many different ways to skin a cat, so they grotesquely say lol.
I just really hope you aren't going to settle with that green for a background color. It gives me a headache looking at it. You could maybe have a forest green #014421 as the background color, white text, and the specific target sections be a lighter green, perhaps a lime with darker text.