Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by hamsternation
hamsternation
26,616 Points

I passed, but i'm not sure what my code is actually doing...

What is my reroll code actually doing?

I tried calling reroll via CapitalismHand.reroll(), CapitalismHand(), assigning CapitalismHand() to an instance, and other ways to seeing what the reroll method is actually doing in my code but I'm still getting doubles with every method. Isn't this reroll code supposed to reroll automatically if the class returns a double? Am I missing something?

How can I test the code to see whether the class rerolled itself or not?

hands.py 
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self):
        super().__init__(size = 2, die_class = D6)

    @classmethod
    def reroll(cls):
        if cls.doubles:
            return cls()

    @property
    def doubles(self):
        truthy = []
        for x in range(1,7):
            if len(self._by_value(x)) == 2:
                truthy.append(True)
            else:
                truthy.append(False)
        return True in truthy




    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,423 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,423 Points

The challenge asks only for a reroll method that return a new instance. The verbiage about why one might use the reroll method due to doubles is not relevant to the code needed to solve the challenge. As for you code, it works but not for the reasons you think:

    @classmethod
    def reroll(cls):  # define a classmethod (here, 'cls' will always point to the current class CapitalismHand
        if cls.doubles:  # without parens, this says if the method object CapitalismHand.doubles exist. This is *always* True.
            return cls()  # return new instance.

So the if statement can be removed and still pass.