Python Object-Oriented Python Dice Roller RPG Roller

Tan Yang
Tan Yang
13,163 Points

I ran my code in Pycham it works, but it doesn't work here, please help to find the reason, really appreciate!

Bummer: Try again! I don't get the point!

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides = 20)
hands.py
from dice import D20

class Hand(list):


    def __init__(self, lst):
        super().__init__(lst)

    @classmethod
    def roll(cls, times = 0):
        lst = []
        for _ in range(times):
            lst.append(dice.D20().value)
        return cls(lst)

    @property
    def total(self):
        return sum(self)

1 Answer

Steven Parker
Steven Parker
155,229 Points

When you "roll", your "hand" should contain D20's, not just their values. And since you imported D20 itself, you don't need to "dice" prefix. So instead of "dice.D20().value", just write "D20()".

Also, it's not necessary to override "__init__".