I tried my code in the python shell, and it does what the instructions call for. But, the challenge says it is wrong.

Question

What is wrong with My Code:
'''def just_right(string):
  if len(string) < 5:
    print("Your string is too short")
  elif len(string) > 5:
    print("Your string is too long")
  else:
    return True
'''

Ryan Ruscett · Accepted Answer

Hola,
Well, your code looks to be right because it's printing the answer to the console. It's not asking you to print the answer it's asking you to return the answer. This means some function called this function and it's returning to it what it needs. It's not printing anything at this point in time. So in the console yes, yours appears to be right, but it's not actually right for which in the context the question is asking.
```python
def just_right(arg1):
  if len(arg1) < 5:
    return "Your string is to short"
  elif len(arg1) > 5:
    return "Your string is to long"
  else:
    return True
```
This code returns the string requested based on the value being passed in depending on if it's more or less than 5. Otherwise it just returns true. 
Does that make sense? If not please let me know your questions or I can try to be more clear.
```

Welcome to the Treehouse Community

Looking to learn something new?

kevin cleary

kevin cleary

I tried my code in the python shell, and it does what the instructions call for. But, the challenge says it is wrong.

1 Answer

Ryan Ruscett

Ryan Ruscett

kevin cleary

kevin cleary

Ryan Ruscett

Ryan Ruscett