I tried to limit to creating one random colour but got stuck –  can someone help review my code please?

Hi Mia Bucci,

I have had a look at your code. There is a problem with how you generate the rgbColor variable.

In order to create an RGB color, you need three values between 0 and 256. This means, that your variable rgbColor will not be correctly generated with your code.

In your code, the value of the rgbColor variable will be one value, i.e. one random number:

rgbColor = Math.floor(Math.random() * 256 )

Instead, it should be:

rgbColor = "rgb(";
  rgbColor += Math.floor(Math.random() * 256 ) + ",";
  rgbColor += Math.floor(Math.random() * 256 ) + ",";
  rgbColor += Math.floor(Math.random() * 256 ) + ")";

Doing this will result in a string, that you can use to insert into the page's html.

If you like have a look at my code (below). I have separated the generating of random number into a separate function RandColor() to make the code easier to read. If you want to generate ten different colors on the page, you wrap the function call into a for loop. If you only want one color to display, just leave the for loop out, as the function will only run once then.

var html = '';
var rgbColor;

function RandColor() {
  return Math.floor(Math.random() * 256 );
}

function getColor() {
  var rgbColor = "rgb(";
  rgbColor += RandColor() + ",";
  rgbColor += RandColor() + ",";
  rgbColor += RandColor() + ")";

  html = '<div style="background-color:' + rgbColor + '"></div>';
  return html;
}

document.write(getColor());

Thanks! I didn't understand the color components but I watched the next video and now i'm clearer!

var html = ''; var color; var rgbColor;

'"></div>';

for (i = 0; i < 10; i++) { color = Math.floor(Math.random() * 256 ); rgbColor = 'rgb(' + color + ',' + color + ',' + color + ')'; html += '<div style="background-color:' + rgbColor + '"></div>'; } document.write(html);