I used a 'for in' loop but the solution didn't. Did I do it wrong?

Question

I completed the challenge successfully using a 'for in' loop but the solution video showed a simple for loop which counted through the object properties, the same as previous challenges. I assumed I would be required to use the new 'for in' loop that I was just taught.

My code:

var message = '';

function print(message) {
  var outputDiv = document.getElementById('output');
  outputDiv.innerHTML = message;
}

for (var prop in students) {
  message += ("<h2>Student: " + students[prop].name + "</h2>");
  message += ("<p> Track: " + students[prop].track);
  message += ("<br> Points: " + students[prop].points);
  message += ("<br>Achievements: " + students[prop].achievements);
}

print(message);

Instructor code using the same object array:

var message = '';
var student;

function print(message) {
  var outputDiv = document.getElementById('output');
  outputDiv.innerHTML = message;
}

for (var i = 0; i < students.length; i += 1) {
  student = students[i];
  message += '<h2>Student: ' + student.name + '</h2>';
  message += '<p>Track :' + student.track + '</p>';
  message += '<p>Points :' + student.points + '</p>';
  message += '<p>Achievements :' + student.achievements + '</p>';
}

print(message);

I don't see that my code is any less efficient but I'm new to this so it might not be obvious. Please let me know if there is good reason to write it how the instructor did.

Thanks for your advice.

Answer 1 · 2018-08-13T20:45:51Z

August 13, 2018 8:45pm

Ideally as long as the code works, everything is fine, especially in the real world. I think the exercise was made to specifically test for the for loop so that's probably why it was marked the way it was.

Welcome to the Treehouse Community

Looking to learn something new?

Russell Wright

Russell Wright

I used a 'for in' loop but the solution didn't. Did I do it wrong?

1 Answer

Julian French

Julian French