Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Posted by DAMAN Mangat
.a{fill-rule:evenodd;}techdegree
DAMAN Mangat
Front End Web Development Techdegree Student 1,466 Points

"i was expecting 'target' to be '_blank' not ' '. " Not sure what im doing wrong:

$("#external").attr("target", "_blank");

What's wrong?

js/app.js 
$("#external").attr("_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

I assume we're talking about the code you showed above "What's wrong?". The code in the blockquote below it is missing the first argument to .attr().

In the first code, it looks like you targeted elements with the ID "external".
:point_right: But the challenge asks you target elements with the class "external".

Nathan Keene
Nathan Keene
7,595 Points

Fair enough, but shouldn't the Challenge be flagging that and then stopping instead of skipping over it to the .attr() method? And why doesn't it point out that one of the arguments is missing?

I've been getting the same error message over and over on this item as well despite intentionally committing a variety of different errors that it seems to be missing (see my question following this one).