Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

Posted by Jessica Orellanes
Jessica Orellanes
11,245 Points

I would like you guys to review my code, i'm sure i'll get helpful feedback

My solution has 10 lines. I tried my best to DRY it. 

function randomColor() {
 function color() {
 return Math.floor(Math.random() * 256 );
 }
 var rgbColor = 'rgb(' + color() + ',' + color() + ',' + color() + ')';
 return '<div style="background-color:' + rgbColor + '"></div>'; 
}
for (var i= 0; i < 10; i +=1) {
  document.write(randomColor());
}
Iain Simmons
Iain Simmons
Treehouse Moderator 32,289 Points

Note that this code won't create the HTML required to display the colored dots, it will just print the text value of the 10 colors, like rgb(123, 45, 67).

1 Answer

ravindra barthwal
ravindra barthwal
2,271 Points
ravindra barthwal
ravindra barthwal
2,271 Points 
function color() {
 return Math.floor(Math.random() * 256 );
}
function randomColor() {
 return 'rgb(' + color() + ',' + color() + ',' + color() + ')';
}
for (var i= 0; i < 10; i++) {
  document.write(randomColor());
}

I just removed one line and the errors in your code. Hope it'll be the best solution to your answer.