Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Laurie Curiant
Laurie Curiant
8,965 Points
Posted by Laurie Curiant
Laurie Curiant
8,965 Points

if else problem

Hi,

I just finish The Student Record Search Challenge but something go wrong. here is my code:

  var students = [ 
    { 
      name: 'Dave',
      track: 'Front End Development',
      achievements: 158,
      points: 14730
    },
    {
      name: 'Jody',
      track: 'iOS Development with Swift',
      achievements: '175',
      points: '16375'
    },
    {
      name: 'Jody',
      track: 'PHP Development',
      achievements: '55',
      points: '2025'
    },
    {
      name: 'John',
      track: 'Learn WordPress',
      achievements: '40',
      points: '1950'
    },
    {
      name: 'Trish',
      track: 'Rails Development',
      achievements: '5',
      points: '350'
    }
  ];



  var message= '';
  var student;

  var search;
  function print(message) {
    var outputDiv = document.getElementById('output');
    outputDiv.innerHTML = message;
  }

  function getStudentReport( student) {
    var report = '<h2>Student: ' +  student.name + '</h2>';
    report += '<p>Track : ' + student.track + '</p>';
    report += '<p>Achievements : ' + student.achievements + '</p>';
    report += '<p>Points : ' + student.points + '</p>';
    return report;
  };

  while(true) {
    search = prompt("qui cherches tu ?");
    if (search === null || search.toLowerCase() === 'quit') {
      break;
    } 
    for (var i = 0; i < students.length; i += 1) {
      student = students[i];
      if( search.toLowerCase() === student.name.toLowerCase()) {

        message =  getStudentReport(student);
        print(message);
      } else {
        message = '<h2>Aucun étudiant nommé <strong>' + search + '</strong></h2>';
        print(message);
      }

    }
  }

when i type quit in the prompt, it go well, when i remove the part :

      else {
        message = '<h2>Aucun étudiant nommé <strong>' + search + '</strong></h2>';
        print(message);
      }

it go well too... but when i let the else part, even if i type a good name in the prompt, it always go in the else part... can someone explain me what i do wrong ?

Thanks for your help.

1 Answer

Sean T. Unwin
Sean T. Unwin
28,690 Points
Sean T. Unwin
Sean T. Unwin
28,690 Points

At the end of the if statement's body, before the else there needs to be a break otherwise the script will continue to run until the for loop is finished.

      if( search.toLowerCase() === student.name.toLowerCase()) {
        message =  getStudentReport(student);
        print(message);
        break; // <---- Add this statement
      } else {
        // ...