Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Andrew Wiley
Andrew Wiley
27,097 Points

I'm getting an infinite Loop in my code. Need help.

import random


words=['red',
      'green',
      'blue',
      'white',
      'black',
      'brown',
      'pink',
      'orange'
]

while True:
    start=input("Press enter/return to start, or Q to quit: ")
    if start.lower()=='q':
        break

    #pick rand word    
    secret_word=random.choice(words)
    bad_guesses=[]
    good_guesses=[]


    while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
        #spaces for letters
        #draw guessed letters and strikes
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
            else:
                print('_', end='')  
        print('')
        print('Strikes: {}/7'.format(len(bad_guesses)))
        print('')
    #take guess
    guess=input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess a single letter")
        continue
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter")
        continue
    elif not guess.isaplha():
        print("You can only guess letters!")
        continue

    if guess in secret_word:
        good_guesses.append(guess)
        if len(good_guesses) == len(list(secret_word)):
            print("You win! The word was: {}".format(secret_word))
            break
        else:
            bad_guesses.append(guess)

    else:
        print("You lose! My secret_word was: {}".format(secret_word))
rydavim
rydavim
18,814 Points

I've added some nice code formatting to your post. You can do this using the following markdown:

```language

your code here

```

2 Answers

Steven Parker
Steven Parker
243,318 Points
Steven Parker
Steven Parker
243,318 Points

Remember that python loop control is all about indentation (spacing). Anything indented to the same level as a while will not be part of the loop.

So as shown, the loop that tests for the number of bad guesses does not include the code below where the guess is asked for.

You probably meant to indent the the code from #take guess on down a bit more so it would be part of the loop.

Josh Milbrandt
Josh Milbrandt
6,209 Points
Josh Milbrandt
Josh Milbrandt
6,209 Points

your indentation is off

        bad_guesses=[]
        good_guesses=[]

        while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
        #spaces for letters
        #draw guessed letters and strikes
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
            else:
                print('_', end='')  
        print('')
        print('Strikes: {}/7'.format(len(bad_guesses)))
        print('')
    #your code never gets past here nothing below this ever runs
    guess=input("Guess a letter: ").lower()

your loop is going forever because bad_guesses is never greater than 7, I think this is just an indentation issue and you meant to put the rest of your code inside that while loop, the rest looks good, python takes some getting used too because there are no curly braces, you have to kind of take a step back and look at it visually to see where the loops begin and end