Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Getter Methods

Elijah Sellers
seal-mask
.a{fill-rule:evenodd;}techdegree
Elijah Sellers
Full Stack JavaScript Techdegree Student 7,785 Points
Posted by Elijah Sellers
.a{fill-rule:evenodd;}techdegree
Elijah Sellers
Full Stack JavaScript Techdegree Student 7,785 Points

I'm not seeing where my conditional statements are wrong? when i run it normally in VS code it runs fine

Per the title. I'm not understanding why my code isnt working anyhelp would be great!

creating_getters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

   get level() {
        if ( this.credit > 90 ) {
        return 'Senior';
      } else if ( this.credit <= 90 && this.credit >= 61 ) {
        return 'Junior';
      } else if ( this.credit <= 60 && this.credit >= 31 ) {
        return 'Sophomore';
      } else {
        return 'Freshman'
      }
    }

    stringGPA() {
        return this.gpa.toString();
    }
}

const student = new Student(3.9);

2 Answers

Steven Parker
Steven Parker
229,644 Points
Steven Parker
Steven Parker
229,644 Points

Very odd that VS Code did not detect the error!

The logic is good, but the name of the attribute should be "credits" (plural) instead of "credit" (singular).

Shawn Lindsey
Shawn Lindsey
20,951 Points
Shawn Lindsey
Shawn Lindsey
20,951 Points

You seem to really know your stuff, so I was curious if there was a reason or any kind of gotcha that should discourage me from formulating my code as follows (this passed the challenge, fwiw):

get level() { if ( this.credit > 90 ) { return 'Senior'; } else if ( this.credit >= 61 ) { return 'Junior'; } else if ( this.credit >= 31 ) { return 'Sophomore'; } else { return 'Freshman'; } }

In other words, it seemed to me that you don't need to get explicit with the middle ranges since it's implied that credit ranges above have already been covered by the logic of the "else if". Hopefully that makes sense; I couldn't think of a better way to put it.

Steven Parker
Steven Parker
229,644 Points
Steven Parker
Steven Parker
229,644 Points

You're quite right, the high end of the range need not be checked since it would have been handled by the previous test.

Shawn Lindsey
Shawn Lindsey
20,951 Points
Shawn Lindsey
Shawn Lindsey
20,951 Points

Awesome, thanks for the response.