Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Nayeon Kim
PLUS
Nayeon Kim
Courses Plus Student 6,718 Points
Posted by Nayeon Kim
Nayeon Kim
Courses Plus Student 6,718 Points

I'm pretty sure that this $(".external a").attr("target","_blank"); is the right answer, but I keep getting it 'wrong'

What am I doing wrong?

js/app.js 
$('.external a').attr("target","_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

2 Answers

Julian Gutierrez
Julian Gutierrez
19,201 Points
Julian Gutierrez
Julian Gutierrez
19,201 Points

Your solution is targeting an anchor tag inside of an element with the class "external". What you need to do is target the element itself both solutions below are possibilities. 

$("a.external").attr("target","_blank");

$(".external").attr("target","_blank");
alastair cooper
alastair cooper
30,617 Points
alastair cooper
alastair cooper
30,617 Points

forget the link element.

just use...

$('.external').attr('target','_blank');