Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Solomon Asiedu-Ofei Jnr
1,015 Pointsim stuck at normalizeDiscountCode java course
So I have used the Regex tester to generate a validation for a string containing only alphabets or $ but my code isn't working. I get an error saying Oops! It looks like Task 1 is no longer passing
import java.io.Console;
import java.util.regex.Pattern;
import java.util.regex.Matcher;
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String upperCodes;
private String normalizeDiscountCode(String discountCode) {
if(discountCode.matches("[a-zA-Z|$]+")){
throw new IllegalArgumentException("Invalid discount code");
}
String upperCodes = discountCode.toUpperCase();
return upperCodes;
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
andren
28,558 PointsYour regex does indeed identity correct discount codes. But you are telling Java to throw an exception if the discount code matches the regex. You should be doing the opposite. An exception should be thrown if the discount code does not match the regex, since that identifies correct discount codes.
This can be achieved by simply reversing the result of the match method by using the ! operator like this:
import java.io.Console;
import java.util.regex.Pattern;
import java.util.regex.Matcher;
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String upperCodes;
private String normalizeDiscountCode(String discountCode) {
if(!discountCode.matches("[a-zA-Z|$]+")){
throw new IllegalArgumentException("Invalid discount code");
}
String upperCodes = discountCode.toUpperCase();
return upperCodes;
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}