Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops A Closer Look at Loop Conditions

Syed Khutub Shariff
Syed Khutub Shariff
2,084 Points
Posted by Syed Khutub Shariff
Syed Khutub Shariff
2,084 Points

Im stuck in Endless loop not able to figure out why?

var upper = 10;
var guess;
var attempts = 0;
var randomNumber = getRandomNumber();


function getRandomNumber(upper) {
  return Math.floor( Math.random() * upper ) + 1;
}

while( guess !== randomNumber){

  guess = getRandomNumber(upper);
  attempts += 1;
 }

document.write("<p>The random number was = " + randomNumber + "<p>");
document.write("<p> the number of attempts =" + attempts + "</p>" );

1 Answer

Steven Parker
Steven Parker
229,657 Points
Steven Parker
Steven Parker
229,657 Points

On line 4, the target "randomNumber" is set by calling "getRandomNumber". But since it it called without an argument, the formula will generate a result that is not a number ("NaN").

Since nothing matches "NaN", the loop condition will never be met and the loop will run continuously.

Just supply an argument when you call "getRandomNumber" (I assume you intended to use "upper") to fix the issue.