Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Delivering the MVP Applying a Discount Code

I'm stuck in this challenge. Please help!

For this first task, create a new private method named normalizeDiscountCode. It should take the discount code that is passed into the method and return the uppercase version. Call it from the current applyDiscountCode method and set this.discountCode to the result.

private String normalizeDiscountCode(String DiscountCode) { return discount.toUpperCase();
}

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
  }
  private String normalizeDiscountCode(String DiscountCode){
    return discount.toUpperCase();                                      
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Brandon Khan
Brandon Khan
21,618 Points

private String normalizeDiscountCode(String DiscountCode){ return discount.toUpperCase(); }

the issue is your variable getting passed in is DiscountCode but the variable you are returning is discount. This function has no variable in its scope named discount to return. If you want to use the passed in variable you need to use DiscountCode as thats the name of any variable passed into this function. it looks like you are also missing a closing } in the code but not in your question.

private String normalizeDiscountCode(String DiscountCode){ return DiscountCode.toUpperCase(); } < - like this.

Caleb Kleveter
Caleb Kleveter
Treehouse Moderator 37,862 Points

Hey Brandon. I just wanted to let you know I changed your comment to answer. This allows people to upvote it if it is helpful and the OP to mark it as 'best'.

Happy coding and thanks for helping in the forums!