Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

Anthony Hind
Anthony Hind
5,715 Points

inherited project

Hi Guys,

I have inherited a project from a developer who has left our company he had uploaded the products and setup the navigation i have started to re design the homepage and other elements of the site just after some general comments from you guys it's on a test domain of http://www.leica-icon.co.uk,

Any hints, tips or comments would be appreciated

Cheers

Ant

6 Answers

Richard Duncan
Richard Duncan
5,568 Points

Hi Ant,

What are you looking for hints and tips on specifically?

At a glance I have run your landing page through the W3C validator which has brought up a few errors. Don't be over-phased by the number reported there many may be tackled in one go if say a script is outputting the content from a loop and omitting a closing tag.

http://validator.w3.org/check?uri=http%3A%2F%2Fwww.leica-icon.co.uk%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

Also I noticed that your meta description and keyword tags exist but contain no information which will negatively affect your SEO score.

Descriptions should be 100-150 characters long and unique and specific to the page being viewed if at all possible, too many duplicate descriptions is bad.

Try and keep keywords relevant and put in order of importance delimited by a comma.

Your 404 error page is generic and reveals that you are using the LemonStand eCommerce Platform which may be a security risk. As you are an online retailer you may wish to create a custom not found page that shows popular products or attempts to offer up a suggestion based on the URL. For example a user navigating directly to http://www.leica-icon.co.uk/category/leica-disto/ may mis-type disto as distRo for example and you could point them in the right direction.

It's not really clear to me as a user why you have two navigation menu's? I always try and think what would a user or crawler make of this if all they could see was the text, which navigation would be prominent and would it be clear where to go for products? HTML 5 also supports a <nav> tag which allows for more semantic markup and additional structure which may aid you here.

Cheers, Rich

Anthony Hind
Anthony Hind
5,715 Points

Cheers Rich,

Some great feedback there, I am currently looking into the errors on the validator it is mainly to do with the custom navigation that was built basically when we add a product into Lemonstand it appears dynamically in the navigation menu but unfortunately it has php partials that integrate the mega menu reloaded that was purchased from code canyon and it is kicking out a lot of errors....

The reason for the two navigation's has been specified the company require a product based main NAV and then a way to get to the key information pages easily that why i incorporated the side nav pop out....

All meta data and other required bits you mention will be incorporated soon again thanks for pointing that out!

Whilst trying to configure the main nav for mobile I have run into many issues what is the overall opinion of using a simpler navigation that swaps the main desktop navigation when smaller than 800px sort of thing is this something that can cause more issues??

If you resize my site shortly you will see the changes i am just about to test on the live domain...

Cheers

Ant

Richard Duncan
Richard Duncan
5,568 Points

I'm enjoying the fluidity Ant. I actually think the nav is much clearer when in one bar at the top and that would be my personal preference. Don't make life difficult, over engineering can make it really difficult to maintain a responsive design. That being said I think hiding the side navs when the screen width is <= 800 is working for your design.

What kind of problems are you having specifically?

Anthony Hind
Anthony Hind
5,715 Points

If you switch between landscape and portrait on your device it just go's all wrong and I cannot find a solution for it!! I have just updated with the default nav for the zest theme that is being used to see if the simpler more basic NAV will do the trick as we are getting near the launch date and I need to finish the product basket pressure isnt the word :)

Ant

Richard Duncan
Richard Duncan
5,568 Points

Try replacing your meta tag for viewport with this:

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />

Richard Duncan
Richard Duncan
5,568 Points

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />

Anthony Hind
Anthony Hind
5,715 Points

Please don't tel me it could be that simple :)

Richard Duncan
Richard Duncan
5,568 Points

The only issue I can see is that DIV.image_carousel.featurette-pattern has a fixed width of 960px when viewing the mobile size which is breaking the view on my iphone.

Anthony Hind
Anthony Hind
5,715 Points

Yeah I noticed that before I'm struggling to find where it is picking up the fixed width from as it is within a row on foundation zurb which is set to 960px but it's supposed to be responsive the size of the images is set in the Jquery function i think that may be causing issues

Ant